Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weak_computed_property rule #2597

Merged
merged 2 commits into from
Jan 27, 2019
Merged

Conversation

marcelofabri
Copy link
Collaborator

Fixes #2596

@SwiftLintBot
Copy link

SwiftLintBot commented Jan 26, 2019

12 Messages
📖 Linting Aerial with this PR took 1.85s vs 1.77s on master (4% slower)
📖 Linting Alamofire with this PR took 3.55s vs 3.52s on master (0% slower)
📖 Linting Firefox with this PR took 12.18s vs 12.84s on master (5% faster)
📖 Linting Kickstarter with this PR took 19.51s vs 19.5s on master (0% slower)
📖 Linting Moya with this PR took 1.89s vs 1.94s on master (2% faster)
📖 Linting Nimble with this PR took 1.92s vs 1.91s on master (0% slower)
📖 Linting Quick with this PR took 0.54s vs 0.56s on master (3% faster)
📖 Linting Realm with this PR took 3.39s vs 3.48s on master (2% faster)
📖 Linting SourceKitten with this PR took 1.2s vs 1.24s on master (3% faster)
📖 Linting Sourcery with this PR took 4.64s vs 4.97s on master (6% faster)
📖 Linting Swift with this PR took 26.0s vs 26.0s on master (0% slower)
📖 Linting WordPress with this PR took 20.39s vs 20.24s on master (0% slower)

Generated by 🚫 Danger

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really ought to simplify the boilerplate for corrections since the implementation is nearly always the same or very close to this pattern.

@marcelofabri
Copy link
Collaborator Author

We really ought to simplify the boilerplate for corrections since the implementation is nearly always the same or very close to this pattern.

Totally agreed. I will try to come up with something when I have some free time.

@marcelofabri marcelofabri merged commit ea9c638 into master Jan 27, 2019
@marcelofabri marcelofabri deleted the mf-weak_computed_property branch January 27, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants