Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lower_acl_than_parent when linting with Swift 5 #2609

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Jan 28, 2019

Fixes #2607

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 2.01s vs 1.83s on master (9% slower)
📖 Linting Alamofire with this PR took 3.93s vs 3.54s on master (11% slower)
📖 Linting Firefox with this PR took 14.07s vs 12.54s on master (12% slower)
📖 Linting Kickstarter with this PR took 23.28s vs 20.7s on master (12% slower)
📖 Linting Moya with this PR took 2.32s vs 1.93s on master (20% slower)
📖 Linting Nimble with this PR took 2.36s vs 2.05s on master (15% slower)
📖 Linting Quick with this PR took 0.66s vs 0.6s on master (10% slower)
📖 Linting Realm with this PR took 3.75s vs 3.65s on master (2% slower)
📖 Linting SourceKitten with this PR took 1.35s vs 1.23s on master (9% slower)
📖 Linting Sourcery with this PR took 5.63s vs 4.77s on master (18% slower)
📖 Linting Swift with this PR took 29.95s vs 28.23s on master (6% slower)
📖 Linting WordPress with this PR took 23.46s vs 20.76s on master (13% slower)

Generated by 🚫 Danger

@jpsim jpsim merged commit 7b447ab into master Jan 28, 2019
@jpsim jpsim deleted the swift-5-fix-lower-acl-than-parent branch January 28, 2019 20:49
@djbe djbe mentioned this pull request Feb 23, 2019
4 tasks
sjavora pushed a commit to sjavora/SwiftLint that referenced this pull request Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants