Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive on number_separator with year integer literals #2642

Merged
merged 7 commits into from
Feb 14, 2019
Merged

Fix false positive on number_separator with year integer literals #2642

merged 7 commits into from
Feb 14, 2019

Conversation

Jeehut
Copy link
Collaborator

@Jeehut Jeehut commented Feb 12, 2019

Fixes #2637.

@SwiftLintBot
Copy link

SwiftLintBot commented Feb 13, 2019 •
edited
Loading

12 Messages
📖 Linting Aerial with this PR took 1.91s vs 1.78s on master (7% slower)
📖 Linting Alamofire with this PR took 3.89s vs 4.01s on master (2% faster)
📖 Linting Firefox with this PR took 12.54s vs 13.08s on master (4% faster)
📖 Linting Kickstarter with this PR took 0.2s vs 0.21s on master (4% faster)
📖 Linting Moya with this PR took 1.86s vs 2.04s on master (8% faster)
📖 Linting Nimble with this PR took 1.78s vs 1.71s on master (4% slower)
📖 Linting Quick with this PR took 0.57s vs 0.55s on master (3% slower)
📖 Linting Realm with this PR took 3.4s vs 3.37s on master (0% slower)
📖 Linting SourceKitten with this PR took 1.11s vs 1.11s on master (0% slower)
📖 Linting Sourcery with this PR took 4.09s vs 3.96s on master (3% slower)
📖 Linting Swift with this PR took 26.83s vs 26.62s on master (0% slower)
📖 Linting WordPress with this PR took 20.67s vs 20.86s on master (0% faster)

Generated by 🚫 Danger

marcelofabri
marcelofabri reviewed Feb 14, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
marcelofabri
marcelofabri approved these changes Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@marcelofabri marcelofabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge it after fixing the conflict and updating the configuration name on CHANGELOG

@Jeehut Jeehut merged commit 0c36874 into master Feb 14, 2019
@Jeehut Jeehut deleted the cg-number_separator-fix branch February 14, 2019 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelofabri marcelofabri marcelofabri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jeehut @SwiftLintBot @marcelofabri