Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested type handling specification to file_name rule #2718

Merged
merged 4 commits into from
Apr 30, 2019

Conversation

fredpi
Copy link
Collaborator

@fredpi fredpi commented Apr 12, 2019

Closes #2717.

@SwiftLintBot
Copy link

SwiftLintBot commented Apr 12, 2019

12 Messages
📖 Linting Aerial with this PR took 3.49s vs 3.15s on master (10% slower)
📖 Linting Alamofire with this PR took 5.79s vs 5.13s on master (12% slower)
📖 Linting Firefox with this PR took 17.36s vs 15.06s on master (15% slower)
📖 Linting Kickstarter with this PR took 27.5s vs 27.19s on master (1% slower)
📖 Linting Moya with this PR took 2.42s vs 2.3s on master (5% slower)
📖 Linting Nimble with this PR took 2.24s vs 2.26s on master (0% faster)
📖 Linting Quick with this PR took 0.8s vs 0.83s on master (3% faster)
📖 Linting Realm with this PR took 3.83s vs 3.75s on master (2% slower)
📖 Linting SourceKitten with this PR took 1.53s vs 1.55s on master (1% faster)
📖 Linting Sourcery with this PR took 5.02s vs 4.99s on master (0% slower)
📖 Linting Swift with this PR took 39.57s vs 38.76s on master (2% slower)
📖 Linting WordPress with this PR took 29.97s vs 29.7s on master (0% slower)

Generated by 🚫 Danger

@fredpi fredpi force-pushed the feature/#2717-file-name-configurability branch from 6a7c87a to fd70437 Compare April 12, 2019 17:17
@fredpi
Copy link
Collaborator Author

fredpi commented Apr 20, 2019

Any thoughts on this? ;)

@fredpi fredpi force-pushed the feature/#2717-file-name-configurability branch from fd70437 to 7b166a0 Compare April 21, 2019 21:05
@jpsim
Copy link
Collaborator

jpsim commented Apr 29, 2019

Thanks for the PR! What are your thoughts on just allowing both dots and no dots without necessarily adding a configuration option for it?

IMHO that would follow the mantra of "don't let your tools get in your way" a lot better than requiring a strict consistent format for nested type extensions.

@fredpi
Copy link
Collaborator Author

fredpi commented Apr 30, 2019

@jpsim This was my first thought as well, but then I figured that one could already exactly specify prefix and suffix patterns, so I thought making the nested type separator just as configurable would make sense (considering that some may also prefer other separators than or . (e. g. _)).

However, I don't care very much about this myself, I just wanted to follow the existing pattern of configurability. If you prefer just allowing certain characters (dot / underscore / no char), I'd happily adjust the PR accordingly. 😉

@fredpi fredpi force-pushed the feature/#2717-file-name-configurability branch from 7b166a0 to a26276b Compare April 30, 2019 07:50
@jpsim
Copy link
Collaborator

jpsim commented Apr 30, 2019

Good point on aligning with the other configurability options. Thanks for the PR @fredpi!

@jpsim jpsim merged commit 3b9917f into realm:master Apr 30, 2019
@fredpi fredpi deleted the feature/#2717-file-name-configurability branch April 30, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nested type handling specification to file_name rule
3 participants