-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nested type handling specification to file_name rule #2718
Add nested type handling specification to file_name rule #2718
Conversation
Generated by 🚫 Danger |
6a7c87a
to
fd70437
Compare
Any thoughts on this? ;) |
fd70437
to
7b166a0
Compare
Thanks for the PR! What are your thoughts on just allowing both dots and no dots without necessarily adding a configuration option for it? IMHO that would follow the mantra of "don't let your tools get in your way" a lot better than requiring a strict consistent format for nested type extensions. |
@jpsim This was my first thought as well, but then I figured that one could already exactly specify prefix and suffix patterns, so I thought making the nested type separator just as configurable would make sense (considering that some may also prefer other separators than However, I don't care very much about this myself, I just wanted to follow the existing pattern of configurability. If you prefer just allowing certain characters (dot / underscore / no char), I'd happily adjust the PR accordingly. 😉 |
7b166a0
to
a26276b
Compare
Good point on aligning with the other configurability options. Thanks for the PR @fredpi! |
Closes #2717.