Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new file_content_type for PreviewProvider subclasses #3063

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

Jeehut
Copy link
Collaborator

@Jeehut Jeehut commented Feb 1, 2020

Fixes #2860.

@Jeehut Jeehut changed the title Add new file_content_type for PreviewProvider subclasses for SwiftUI support Add new file_content_type for PreviewProvider subclasses Feb 1, 2020
@Jeehut Jeehut force-pushed the cg-file-types-order branch 2 times, most recently from 26e2a95 to ad3bdec Compare February 1, 2020 13:02
@SwiftLintBot
Copy link

SwiftLintBot commented Feb 1, 2020

1 Error
🚫 Please rebase to get rid of the merge commits in this PR
13 Messages
📖 Linting Aerial with this PR took 1.44s vs 1.38s on master (4% slower)
📖 Linting Alamofire with this PR took 2.35s vs 2.33s on master (0% slower)
📖 Linting Firefox with this PR took 8.53s vs 8.58s on master (0% faster)
📖 Linting Kickstarter with this PR took 13.97s vs 14.0s on master (0% faster)
📖 Linting Moya with this PR took 1.3s vs 1.34s on master (2% faster)
📖 Linting Nimble with this PR took 1.33s vs 1.32s on master (0% slower)
📖 Linting Quick with this PR took 0.53s vs 0.53s on master (0% slower)
📖 Linting Realm with this PR took 2.35s vs 2.32s on master (1% slower)
📖 Linting SourceKitten with this PR took 1.0s vs 1.0s on master (0% slower)
📖 Linting Sourcery with this PR took 6.76s vs 6.79s on master (0% faster)
📖 Linting Swift with this PR took 12.68s vs 12.65s on master (0% slower)
📖 Linting WordPress with this PR took 15.49s vs 15.43s on master (0% slower)
📖 This PR fixed a violation in Alamofire: /watchOS Example/watchOS Example WatchKit Extension/ContentView.swift:28:1: warning: File Types Order Violation: A 'main_type' should not be placed amongst the file type(s) 'supporting_type'. (file_types_order)

Generated by 🚫 Danger

@Jeehut Jeehut requested review from jpsim and PaulTaykalo and removed request for jpsim February 1, 2020 13:16
@PSchmiedmayer
Copy link

@Jeehut I think this is a great addition to the file_content_type rule, thanks!
@PaulTaykalo @ZevEisenberg Any update to when it would be possible to merge this into master? Any way I could help there?

@PaulTaykalo PaulTaykalo merged commit 5a22b94 into master Apr 24, 2020
pull bot pushed a commit to scope-demo/SwiftLint that referenced this pull request Apr 24, 2020
Fixes realm#2860.

Co-authored-by: Paul Taykalo <tt.kilew@gmail.com>
@Jeehut Jeehut deleted the cg-file-types-order branch April 24, 2020 17:30
@M0rtyMerr
Copy link
Contributor

@Jeehut @PaulTaykalo @ZevEisenberg this feature is mentioned in 0.39.0 release notes in CHANGELOG, however, it's not available in pod, which is very confusing and looks like an accidental mistake. Is there anything blocking that from release? It would be awesome to get this feature :)
Sincerely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file_types_order: false positive with PreviewProvider subclasses in SwiftUI
6 participants