New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives in extension_access_modifier with Swift 5.2 #3153

Merged

marcelofabri merged 2 commits into master from mf-bugfix-3150

Aug 6, 2020

Collaborator

marcelofabri commented Mar 27, 2020

No description provided.

SwiftLintBot commented Mar 27, 2020 •

edited

Loading

	12 Messages
📖	Linting Aerial with this PR took 0.7s vs 0.68s on master (2% slower)
📖	Linting Alamofire with this PR took 0.92s vs 0.92s on master (0% slower)
📖	Linting Firefox with this PR took 3.56s vs 3.42s on master (4% slower)
📖	Linting Kickstarter with this PR took 6.0s vs 5.79s on master (3% slower)
📖	Linting Moya with this PR took 0.48s vs 0.47s on master (2% slower)
📖	Linting Nimble with this PR took 0.56s vs 0.64s on master (12% faster)
📖	Linting Quick with this PR took 0.31s vs 0.31s on master (0% slower)
📖	Linting Realm with this PR took 1.05s vs 1.04s on master (0% slower)
📖	Linting SourceKitten with this PR took 0.47s vs 0.47s on master (0% slower)
📖	Linting Sourcery with this PR took 2.46s vs 2.41s on master (2% slower)
📖	Linting Swift with this PR took 8.38s vs 8.36s on master (0% slower)
📖	Linting WordPress with this PR took 6.57s vs 6.43s on master (2% slower)

Generated by 🚫 Danger

Contributor

daltonclaybrook commented Mar 28, 2020

Fixes #3150

superarts commented Jun 29, 2020

Any plan when this PR can be merged please?


          Fix false positives in extension_access_modifier with Swift 5.2

bb372c2

marcelofabri force-pushed the mf-bugfix-3150 branch from 46a69cb to bb372c2 Compare

August 6, 2020 04:36


          Ignore local vars and params

4756ce6

Collaborator Author

marcelofabri commented Aug 6, 2020

This is the output of oss-check with Swift 5.2:

Message: This PR fixed a violation in Alamofire: /Source/AFError.swift:215:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Alamofire: /Source/Notifications.swift:49:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabManager.swift:580:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Firefox: /Client/Frontend/AuthenticationManager/BasePasscodeViewController.swift:38:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift:332:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Firefox: /Client/Frontend/Widgets/PhotonActionSheet/PageActionMenu.swift:18:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Firefox: /Client/Telemetry/TelemetryWrapper.swift:271:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Firefox: /Client/UIScrollViewSwizzled.swift:19:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Kickstarter: /Library/ViewModels/SettingsNotificationCellViewModel.swift:203:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Kickstarter: /KsApi/models/CommentsEnvelope.swift:18:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Sourcery: /SourceryRuntime/Sources/Coding.generated.swift:9:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in Sourcery: [/SourceryTests/Stub/Performance-Code/Kiosk/Auction Listings/TableCollectionViewCell.swift:71:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)](https://github.com/krzysztofzablocki/Sourcery/blob/e15dcb63d4f2dde6fa7abd6fd816e8be769478fd/SourceryTests/Stub/Performance-Code/Kiosk/Auction Listings/TableCollectionViewCell.swift#L71:1)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/Models/Blog+QuickStart.swift:3:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/Models/Notifications/Notification.swift:173:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/NSAttributedString+StyledHTML.swift:3:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/NSURLCache+Helpers.swift:6:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/Notifications/Notification+Interface.swift:6:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: [/WordPress/Classes/Extensions/Colors and Styles/WPStyleGuide+ApplicationStyles.swift:4:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)](https://github.com/wordpress-mobile/WordPress-iOS/blob/9209d07555c7c875e944436cd5423a4947f0ccd4/WordPress/Classes/Extensions/Colors and Styles/WPStyleGuide+ApplicationStyles.swift#L4:1)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/UIImage+Export.swift:4:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/System/WordPressAppDelegate.swift:709:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/WPStyleGuide+Reader.swift:7:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderStreamViewController+Helper.swift:3:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Post/PostEditor+Publish.swift:346:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Blog/WPStyleGuide+Sharing.swift:8:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/System/NetworkAware.swift:57:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/System/NetworkAware.swift:76:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController+JetpackPrompt.swift:1:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/Services/MediaCoordinator.swift:711:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/Classes/Utility/CoreDataHelper.swift:177:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/WordPressUITests/Utils/XCTest+Extensions.swift:39:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
Message: This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/ShareModularViewController.swift:215:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)

marcelofabri merged commit 1dbe1f2 into master

marcelofabri deleted the mf-bugfix-3150 branch

August 6, 2020 05:14

marcelofabri mentioned this pull request

False positive extension_access_modifier with Xcode 11.4 #3150

Closed

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet