Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test testDetectSwiftVersion for Swift 5.2.5 #3299

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

cfiken
Copy link
Contributor

@cfiken cfiken commented Aug 13, 2020

Swift 5.2.5 is released. https://swift.org/download/

Now CI realm.SwiftLint (linux swift52) failed like this.
It is probably due to the swift5.2 container image update.
This PR supports Swift 5.2.5 in the test testDetectSwiftVersion.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #3299 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3299   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files         416      416           
  Lines       20349    20351    +2     
=======================================
+ Hits        18435    18437    +2     
  Misses       1914     1914           
Impacted Files Coverage Δ
...ts/SwiftLintFrameworkTests/SwiftVersionTests.swift 100.00% <100.00%> (ø)
...ftLintFramework/Rules/Lint/PrivateOutletRule.swift 96.15% <0.00%> (-3.85%) ⬇️
...iftLintFramework/Extensions/String+SwiftLint.swift 96.36% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8ad1d...1b95821. Read the comment docs.

@jpsim
Copy link
Collaborator

jpsim commented Aug 13, 2020

Thanks!

@jpsim jpsim merged commit 7feb50f into realm:master Aug 13, 2020
@cfiken cfiken deleted the fix_swift_version_test branch August 14, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants