Add new type-safe ArrayInitRule #3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
jpsim
approved these changes
Mar 23, 2022
Source/SwiftLintFramework/Rules/Lint/TypesafeArrayInitRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintFramework/Rules/Lint/TypesafeArrayInitRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintFramework/Rules/Lint/TypesafeArrayInitRule.swift
Outdated
Show resolved
Hide resolved
| import Foundation | ||
| import SourceKittenFramework | ||
|
|
||
| public struct TypesafeArrayInitRule: AnalyzerRule, ConfigurationProviderRule, OptInRule, AutomaticTestableRule { |
There was a problem hiding this comment.
All analyzer rules are opt-in
Suggested change
| public struct TypesafeArrayInitRule: AnalyzerRule, ConfigurationProviderRule, OptInRule, AutomaticTestableRule { | |
| public struct TypesafeArrayInitRule: AnalyzerRule, ConfigurationProviderRule, AutomaticTestableRule { |
There was a problem hiding this comment.
I wonder whether redundant protocol conformances could be flagged by yet another analyzer rule. 🤔
There was a problem hiding this comment.
Not a big deal, just redundant. I think a pre-typechecked lint rule would be sufficient though.
|
Feel free to merge after you've considered my feedback. |
2 tasks
The idea of this new Analyzer rule is to filter the calls of `map` before they are passed on to the classic ArrayInitRule which does the detailed checking of the lambda function block. The rule makes sure that only the `map` function is considered that is defined by the `Sequence` protocol.
SimplyDanny
force-pushed
the
typesafe-array-init-rule
branch
from
c913a13
to
57bd3b3
Compare
coffmark
pushed a commit
to coffmark/SwiftLint
that referenced
this pull request
Apr 11, 2022
The idea of this new Analyzer rule is to filter the calls of `map` before they are passed on to the classic ArrayInitRule which does the detailed checking of the lambda function block. The rule makes sure that only the `map` function is considered that is defined by the `Sequence` protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this new Analyzer rule is to filter the calls of
mapbefore they are passed on to the classic ArrayInitRule which does the detailed checking of the lambda function block. The rule makes sure that only themapfunction is considered that is defined by theSequenceprotocol.This new rule provides a fix for #3749.