-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opening_brace rule bug fixes #4658
Merged
SimplyDanny
merged 4 commits into
realm:main
from
mildm8nnered:mildm8nnered-opening-brace-rule-bug-fixes
Dec 25, 2022
Merged
opening_brace rule bug fixes #4658
SimplyDanny
merged 4 commits into
realm:main
from
mildm8nnered:mildm8nnered-opening-brace-rule-bug-fixes
Dec 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation missed in subsequent function
mildm8nnered
changed the title
Mildm8nnered opening brace rule bug fixes
opening_brace rule bug fixes
Dec 24, 2022
SimplyDanny
approved these changes
Dec 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3712
In the example given for the defect
The
if
in#endif
was being matched by the regex. I added in a word boundary (\b
), to make sure thatif
,guard
andwhile
are only matched if they start at a word boundary