Remove whitespace from TODO message #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you please add a changelog entry? |
| @@ -58,6 +58,8 @@ public struct TodoRule: ConfigurationProviderRule { | |||
| message = message.stringByReplacingOccurrencesOfString("TODO", withString: "") | |||
| } | |||
| message = message.stringByReplacingOccurrencesOfString("//", withString: "") | |||
| // trim whitespace | |||
| message = message.stringByTrimmingCharactersInSet(NSCharacterSet.whitespaceAndNewlineCharacterSet()) | |||
There was a problem hiding this comment.
please omit NSCharacterSet:
// trim whitespace
message = message.stringByTrimmingCharactersInSet(.whitespaceAndNewlineCharacterSet())
Current coverage is 88.53% (diff: 100%)@@ master #801 diff @@
==========================================
Files 81 81
Lines 2771 2773 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2453 2455 +2
Misses 318 318
Partials 0 0
|
| @@ -15,6 +15,10 @@ | |||
|
|
|||
| ##### Bug Fixes | |||
|
|
|||
| * Fixed whitespace being added to TODO messages | |||
There was a problem hiding this comment.
missing period and two trailing spaces as defined in CONTRIBUTING.md
|
Would it make sense to remove the "TODOs should be avoided: " part of the message since this seems to be more of a feature now? |
|
Not sure about that, but PR looks good. Thanks @wbagdon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.