-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HTML+CSS] Cleaned up front end HTML & CSS. Fixes #95. #203
Conversation
@jpsim https://static.realm.io/alamofire-jp-frontend-cleanup is a 404 ATM, likely permissions |
The links were wrong when I first created the issue. Here are the right links: |
d1d7776
to
20a34cf
Compare
@jpsim - new design looks great! I think this is a huge improvement. 👏 👏 |
Yes +1 |
20a34cf
to
f908904
Compare
@jpsim Very sharp. Nice work! :) |
Code blocks look weird |
That looks pretty funny. What browser are you using? I can't see that in either Safari or Chrome. |
No visible scrollbar for declarations that overflow |
Safari -- I think it's leaving room for the scrollbar when there is none? |
The line under the header looks weird: https://www.dropbox.com/s/ixfk1hx883zz7e5/Screenshot%202015-04-06%2009.55.11.png?dl=0 |
Too much spacing before |
Extra space between |
@@ -10,6 +10,10 @@ | |||
[segiddins](https://github.com/segiddins) | |||
[#196](https://github.com/realm/jazzy/issues/196) | |||
|
|||
* Cleaned up front end HTML & CSS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically it's SCSS
@jpsim this is awesome! See my comments above, but I'm also curious to know that things are still right in Dash? |
Things look fine in Dash to me. |
From Sam's feedback, the biggest stoppers to merging this are:
Sam, are you ok to address these? |
@jpsim yup, I can address all of them relatively shortly. |
75debe3
to
23df9bf
Compare
@jpsim think I cleaned up after my comments? |
Please update the integration specs, then merge away, Sam! |
[HTML+CSS] Cleaned up front end HTML & CSS. Fixes #95.
Also addresses #175. This is necessarily a large PR since it touches on the overall front end design and should have been done at the project's inception. But it cuts the number of lines of CSS from 927 to 418 by deduplicating CSS logic and rules that used to override due to the CSS being hacked together from Apple's source and us adding in styling in an ad-hoc fashion.
If you'd like to review these changes, I'd appreciate if you could browse Alamofire's HTML docs from this branch and compare to what's currently generated by the master branch.
Some of these changes may feel like a step backwards design-wise, but it should be much simpler to change things now.
Feedback is very appreciated at this point, so please speak up about what you dislike @segiddins @yoshyosh @beltex @jessesquires.