Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTML+CSS] Cleaned up front end HTML & CSS. Fixes #95. #203

Merged
merged 5 commits into from
Apr 8, 2015

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Apr 4, 2015

Also addresses #175. This is necessarily a large PR since it touches on the overall front end design and should have been done at the project's inception. But it cuts the number of lines of CSS from 927 to 418 by deduplicating CSS logic and rules that used to override due to the CSS being hacked together from Apple's source and us adding in styling in an ad-hoc fashion.

If you'd like to review these changes, I'd appreciate if you could browse Alamofire's HTML docs from this branch and compare to what's currently generated by the master branch.

Some of these changes may feel like a step backwards design-wise, but it should be much simpler to change things now.

Feedback is very appreciated at this point, so please speak up about what you dislike @segiddins @yoshyosh @beltex @jessesquires.

@orta
Copy link
Collaborator

orta commented Apr 4, 2015

@jpsim https://static.realm.io/alamofire-jp-frontend-cleanup is a 404 ATM, likely permissions

@jpsim
Copy link
Collaborator Author

jpsim commented Apr 4, 2015

The links were wrong when I first created the issue. Here are the right links:

@jpsim jpsim force-pushed the jp-frontend-cleanup branch from d1d7776 to 20a34cf Compare April 5, 2015 00:17
@jessesquires
Copy link
Contributor

@jpsim - new design looks great! I think this is a huge improvement. 👏 👏

@orta
Copy link
Collaborator

orta commented Apr 5, 2015

Yes +1
Feels much much nicer, will be very glad to get this on CocoaDocs.

@jpsim jpsim force-pushed the jp-frontend-cleanup branch from 20a34cf to f908904 Compare April 5, 2015 04:37
@beltex
Copy link
Contributor

beltex commented Apr 5, 2015

@jpsim Very sharp. Nice work! :)

@segiddins
Copy link
Collaborator

@jpsim
Copy link
Collaborator Author

jpsim commented Apr 6, 2015

That looks pretty funny. What browser are you using? I can't see that in either Safari or Chrome.

@segiddins
Copy link
Collaborator

No visible scrollbar for declarations that overflow
https://www.dropbox.com/s/ey14yh1za872f7m/Screenshot%202015-04-06%2009.53.06.png?dl=0

@segiddins
Copy link
Collaborator

That looks pretty funny. What browser are you using? I can't see that in either Safari or Chrome.

Safari -- I think it's leaving room for the scrollbar when there is none?

@segiddins
Copy link
Collaborator

@segiddins
Copy link
Collaborator

@segiddins
Copy link
Collaborator

@@ -10,6 +10,10 @@
[segiddins](https://github.com/segiddins)
[#196](https://github.com/realm/jazzy/issues/196)

* Cleaned up front end HTML & CSS.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically it's SCSS

@segiddins
Copy link
Collaborator

@jpsim this is awesome! See my comments above, but I'm also curious to know that things are still right in Dash?

@jpsim
Copy link
Collaborator Author

jpsim commented Apr 6, 2015

Things look fine in Dash to me.

@jpsim
Copy link
Collaborator Author

jpsim commented Apr 7, 2015

From Sam's feedback, the biggest stoppers to merging this are:

Sam, are you ok to address these?

@segiddins
Copy link
Collaborator

@jpsim yup, I can address all of them relatively shortly.

@segiddins segiddins self-assigned this Apr 7, 2015
@segiddins segiddins force-pushed the jp-frontend-cleanup branch from 75debe3 to 23df9bf Compare April 7, 2015 23:15
@segiddins
Copy link
Collaborator

@jpsim think I cleaned up after my comments?

@jpsim
Copy link
Collaborator Author

jpsim commented Apr 8, 2015

Please update the integration specs, then merge away, Sam!

segiddins added a commit that referenced this pull request Apr 8, 2015
[HTML+CSS] Cleaned up front end HTML & CSS. Fixes #95.
@segiddins segiddins merged commit 57c9456 into master Apr 8, 2015
@segiddins segiddins deleted the jp-frontend-cleanup branch April 8, 2015 18:28
@pigeondotdev pigeondotdev modified the milestone: The Past Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants