Safe url naming #304
Closed
Safe url naming #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,5 +30,9 @@ class SourceDeclaration | |||
| def overview | |||
| "#{abstract}\n\n#{discussion}".strip | |||
| end | |||
|
|
|||
| def filename | |||
| FilenameCleaner.sanitize("#{name}") | |||
There was a problem hiding this comment.
No need for string interpolation
|
That gem seems to bring in a bunch of dependencies... Are we sure active support doesn't just have a method for this we could use? |
|
As far as I have read, there is no built-in way of escaping strings so they are safe for the filesystem. url = "init(baseURL:sessionConfig:requestSerializer:responseSerializer:)"
url.gsub(/[^\w\.]/, '')
=> "initbaseURLsessionConfigrequestSerializerresponseSerializer" |
|
@segiddins do you have an opinion on the above? |
|
sure, using file-cleaner is fine if @jpsim is ok with it |
|
Seems that file-cleaner does not copy the input and hence changes the input. head :001 > require "filename_cleaner"
=> true
head :002 > name = "Global Variables"
=> "Global Variables"
head :003 > new_name = FilenameCleaner.sanitize(name, '_', false)
=> "Global_Variables"
head :004 > name
=> "Global_Variables"I'm not that familiar with Ruby but it seems odd to me that I'm responsible for sending in a copy. |
|
Unless I'm missing something, it does seem like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My take on #146
Requires realm/jazzy-integration-specs#4 to pass build