Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting (#473) #474

Merged
merged 1 commit into from
Feb 6, 2016
Merged

Fix sorting (#473) #474

merged 1 commit into from
Feb 6, 2016

Conversation

esad
Copy link
Collaborator

@esad esad commented Feb 4, 2016

Proposed fix for sorting bug, per #473

@pcantrell
Copy link
Collaborator

I'm surprised to learn that sort_by is unstable! I'm also surprised that this hasn't been causing spurious spec failures more often.

Clear bug, good fix.

pcantrell added a commit that referenced this pull request Feb 6, 2016
@pcantrell
Merge pull request #474 from PSPDFKit-labs/fix-sort
2fc384d 
Stable sorting (#473)
@pcantrell pcantrell merged commit 2fc384d into realm:master Feb 6, 2016
@jpsim
Copy link
Collaborator

jpsim commented Mar 18, 2016

👍 thanks for this!

@jpsim jpsim mentioned this pull request Apr 6, 2016
Closed
@pigeondotdev pigeondotdev modified the milestone: The Past Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcantrell pcantrell

@jpsim jpsim

Labels
bug enhancement github-review-accepted
Projects
None yet
Milestone
Before
Development

Successfully merging this pull request may close these issues.
4 participants
@esad @pcantrell @jpsim @pigeondotdev