Autolink declarations within declarations and fix self-linking #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uped and ungrouped docs. Necessary for autolink to be able to correctly find enums.
Version 0.6.1
…enames and style/rubocop fixes.
…uped and ungrouped docs. Necessary for autolink to be able to correctly find enums.
…enames and style/rubocop fixes.
…s equal, to prevent linking to the same page in certain cases.
…autolinking to different declarations on the same page
* master: use module name for dash keyword release 0.6.3 Use SourceKitten's toolchain resolution if no Swift version is specified update integrate specs [ci skip] update integration specs don't document clang-unexposed Objective-C declarations allow danger to fail on CI update SourceKitten to 0.13.0
Closed
| !link_target.type.extension? && | ||
| link_target.url && | ||
| link_target.url != doc.url.split('#').first && # Don't link to parent | ||
| link_target.url != doc.url # Do not link to self |
There was a problem hiding this comment.
Arrrgh, can we have this be either both "Don't" or "Do not" for consistency (my OCD kicking in)
There was a problem hiding this comment.
lol, this is why everyone has love/hate relationships with code linters! I'll change the other one to "Don't" too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all @esad's work, I just fixed a few merge conflicts with
masterand rebuilt the integration specs.Integration specs diff: realm/jazzy-integration-specs@3159385
@esad I suspect that this will hurt performance when generating the PSPDFKit docs since your API is pretty big and that the bulk of the time spent before this was in auto-linking IIRC. It might be worth focusing on performance improvements after this is merged.