Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove directories before symlinking, fixes installation from Gemfile #595

Closed
wants to merge 1 commit into from
Closed

Remove directories before symlinking, fixes installation from Gemfile #595

wants to merge 1 commit into from

Conversation

meleyal
Copy link
Contributor

@meleyal meleyal commented Jun 14, 2016

Fixes #438

@meleyal meleyal mentioned this pull request Jun 14, 2016
Closed
@DangerCI
Copy link

DangerCI commented Jun 14, 2016 •
edited
Loading 

      <tr>
    <td>:white_check_mark:</td>
    <td data-sticky="true"><del><p>Please include a CHANGELOG entry.

You can find it at CHANGELOG.md.


        :white_check_mark: Yay.
    
  </th>
 </tr>

      <tr>
    <td>:white_check_mark:</td>
    <td data-sticky="true"><del>Note, we hard-wrap at 80 chars and use 2 spaces after the last line.</del></td>
  </tr>

        :white_check_mark: Well done.
    
  </th>
 </tr>

Generated by 🚫 danger

segiddins
segiddins reviewed Jun 14, 2016
View reviewed changes
lib/jazzy/SourceKitten/Rakefile
@@ -6,6 +6,8 @@ task :prepare do
Dir.chdir(fw) do
basename = File.basename(fw, '.framework')
FileUtils.rm_f(basename)
FileUtils.rm_f('Versions/Current')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be rm_rf?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No since they're symlinks, not directories

@meleyal meleyal force-pushed the fix-install-from-gemfile branch from f875fb9 to 4a25bc9 Compare June 15, 2016 08:22
@jpsim
Copy link
Collaborator

jpsim commented Jun 15, 2016

Cherry picked in 8b88e33. Thanks @meleyal!

@jpsim jpsim closed this Jun 15, 2016
@meleyal meleyal deleted the fix-install-from-gemfile branch June 16, 2016 09:10
@pigeondotdev pigeondotdev modified the milestone: The Past Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpsim jpsim

Labels
duplicate enhancement
Projects
None yet
Milestone
Before
Development

Successfully merging this pull request may close these issues.
5 participants
@meleyal @DangerCI @jpsim @segiddins @pigeondotdev