Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #429 generic type #696

Closed
wants to merge 3 commits into from
Closed

Fix #429 generic type #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
235b1fe
Fixes #429 by ignoring generic parameters
SDGGiesbrecht Dec 10, 2016
eb9f4aa
Entered note in changelog.
SDGGiesbrecht Dec 11, 2016
e0856ae
Fixed #429 changelog entry.
SDGGiesbrecht Dec 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
[Thibaud Robelain](https://github.com/thibaudrobelain)
[#600](https://github.com/realm/jazzy/issues/600)

* Fix issue where generic type parameters registered as undocumented symbols.
[Jeremy David Giesbrecht](https://github.com/SDGGiesbrecht)
[#429](https://github.com/realm/jazzy/issues/429)

## 0.7.3

##### Breaking
Expand Down
4 changes: 3 additions & 1 deletion lib/jazzy/sourcekitten.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,9 @@ def self.process_undocumented_token(doc, declaration)
filepath = doc['key.filepath']
objc = Config.instance.objc_mode
if filepath && (filepath.start_with?(source_directory) || objc)
@undocumented_decls << declaration
if doc['key.kind'] != 'source.lang.swift.decl.generic_type_param'
@undocumented_decls << declaration
end
end
return nil if !documented_child?(doc) && @skip_undocumented
make_default_doc_info(declaration)
Expand Down