Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report skipped and included declarations #809

Closed
wants to merge 1 commit into from
Closed

Conversation

johnfairh
Copy link
Collaborator

This adds a report to stdout about the number of declarations included/skipped in the docs, pretty much per #238, eg.

included 964 public or open symbols
skipped 189 private, fileprivate, or internal symbols (use `--min_acl` to see)

New users are still having acl problems with their first use of jazzy, maybe this will help some.

@johnfairh johnfairh closed this May 11, 2017
@johnfairh johnfairh deleted the issue-238 branch May 11, 2017 12:06
@jpsim
Copy link
Collaborator

jpsim commented May 11, 2017

Curious why you closed this @johnfairh, as this does seem pretty useful.

@johnfairh
Copy link
Collaborator Author

I panicked, basically 😆 -- I missed entirely that the specs master had moved on + thought I'd done something unintentionally. Continued in #811.

@jpsim
Copy link
Collaborator

jpsim commented May 11, 2017

I missed entirely that the specs master had moved on

Argh, this is my fault. I was in the process of updating the specs to use Xcode 8.3.2 and didn't expect CI to fail (#800). I was too optimistic and pushed the changes to specs master.

I should get CI to pass with those changes asap. I'll rebuild with your changes in #811 afterwards, so no need to update the specs there beyond what you've already done. Sorry for the trouble.

@johnfairh
Copy link
Collaborator Author

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants