display doc coverage #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #63 |
- sourcekitten 0.1.9 - jazzy 0.0.14
jpsim
force-pushed
the
jp-doc-coverage
branch
from
047f399 to
de553e6
Compare
|
@segiddins could you please review this? |
|
Looks good to me, anything in particular you want me to focus on? |
|
nothing specifically, though the merging of |
|
It makes total sense to me, this way config options are split out from top-level info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have to move the doc coverage inline CSS to
jazzy.scss.I'd like to create a class to encapsulate global module data and options (which would contain, for example
options,doc_structureanddoc_coverage).