Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declarations for undocumented symbols #897

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Fix declarations for undocumented symbols #897

merged 1 commit into from
Oct 25, 2017

Conversation

johnfairh
Copy link
Collaborator

First step towards improved Swift declarations. This PR fixes/adds declarations for undocumented symbols: currently these symbols either get no declaration or (wrongly) get a copy of their parent's declaration (#864).

I think it is useful to include the declarations for undocumented symbols in the docs: helps users understand the API; from the spec projects is not uncommon to leave some members uncommented.

Specs changes, pretty ugly in the (common) 'wrong parent decl -> correct decl' case :/

misc_jazzy_objc_features

  • Add decls for undocumented symbols

document_moya_podspec

  • CancellableToken, CredentialsPlugin, Endpoint, MoyaProvider, NetworkActivityPlugin, NetworkLoggerPlugin, Response, AuthorizationType, MultiTarget, NetworkActivityChangeType, Method, SignalProducerProtocol, Cancellable, TargetType, FormDataProvider - fix incorrect member decls
  • MoyaError, convertResponseToResult(_:request:data:error:), MoyaProviderType, ProgressResponse - add decl for undocumented symbols

document_realm_swift

  • Object - remove incorrect declaration from #ifdef’d out version of className.

document_siesta

  • RequestError.Cause.* -- fix incorrect member decls

misc_jazzy_features

  • Various, add decls for undocumented symbols & fix incorrect member decls.
  • Add specific new test for #ifdef case.
  • Minor change to how unwanted generic type params are documented - still wrong though.

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! The #ifdef case definitely still needs work, but that's out of scope for this PR.

image

Always show the declaration if we know it.
If we don't have a declaration then make sure mustache
knows we don't want the one belonging to the parent.
@johnfairh johnfairh merged commit 5a1b4c1 into master Oct 25, 2017
@johnfairh
Copy link
Collaborator Author

I rebased this to fix conflicts + CI fell over because shields.io have tweaked the badge format. Tempting to take this file out of the CI compare but have kept it for now -- useful to check jazzy is sending the right commands to create a badge at all.

@jpsim
Copy link
Collaborator

jpsim commented Oct 25, 2017

Ugh, sorry about that. That doesn't sound fun. Ideally, I'd like to just generate those SVGs locally in jazzy itself, rather than have to make a network call.

@SDGGiesbrecht
Copy link
Contributor

I’d like to just generate those SVGs locally in jazzy itself, rather than have to make a network call.

I run diff in CI to verify documentation is up‐to‐date and not forgotten, and this, combined with network fluctuations, causes false positives/negatives up to about 10% of the time some weeks.

Needless to say, such a change would be a very welcome!

@segiddins
Copy link
Collaborator

I have SVG generation working locally

@sw-tt-ravivora
Copy link

Hi,
Is this issue is fixed ?

@johnfairh
Copy link
Collaborator Author

@sw-tt-ravivora this PR was included in release 0.9.0. Please open a fresh issue if you're seeing a problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants