-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix declarations for undocumented symbols #897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always show the declaration if we know it. If we don't have a declaration then make sure mustache knows we don't want the one belonging to the parent.
I rebased this to fix conflicts + CI fell over because shields.io have tweaked the badge format. Tempting to take this file out of the CI compare but have kept it for now -- useful to check jazzy is sending the right commands to create a badge at all. |
Ugh, sorry about that. That doesn't sound fun. Ideally, I'd like to just generate those SVGs locally in jazzy itself, rather than have to make a network call. |
I run Needless to say, such a change would be a very welcome! |
I have SVG generation working locally |
Hi, |
@sw-tt-ravivora this PR was included in release 0.9.0. Please open a fresh issue if you're seeing a problem! |
First step towards improved Swift declarations. This PR fixes/adds declarations for undocumented symbols: currently these symbols either get no declaration or (wrongly) get a copy of their parent's declaration (#864).
I think it is useful to include the declarations for undocumented symbols in the docs: helps users understand the API; from the spec projects is not uncommon to leave some members uncommented.
Specs changes, pretty ugly in the (common) 'wrong parent decl -> correct decl' case :/
misc_jazzy_objc_features
document_moya_podspec
document_realm_swift
className
.document_siesta
misc_jazzy_features