Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make websocket error logging exceptionally verbose #3459

Merged
merged 5 commits into from
Oct 10, 2023

better whitespace

a369366
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Make websocket error logging exceptionally verbose #3459

better whitespace
a369366
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results Code Coverage failed Oct 9, 2023 in 1s

Results Code Coverage ❌

Tests failed

❌ TestResults.Linux.xml

5712 tests were completed in 1129s with 5692 passed, 3 failed and 17 skipped.

Test suite Passed Failed Skipped Time
Realm.Tests.dll.Realms.Tests.Sync.FlexibleSyncTests. 72✔️ 1❌ 113s
Realm.Tests.dll.Realms.Tests.Sync.FlexibleSyncTests.Results_Subscribe_Always_WaitsForChanges. 2❌ 4s

❌ Realm.Tests.dll.Realms.Tests.Sync.FlexibleSyncTests.

Realms.Tests.Sync.FlexibleSyncTests
  ✔️ Integration_AfterAnError_CanRecover
  ✔️ Integration_CloseRealmBeforeWaitCompletes
  ✔️ Integration_CreateObjectNotMatchingSubscriptions_ShouldError
  ✔️ Integration_RealmRemoveAllWithSubscriptions
  ✔️ Integration_SubscriptionOnUnqueryableField_ShouldAddThemAutomatically
  ✔️ Integration_SubscriptionSet_AddRemove
  ✔️ Integration_SubscriptionSet_MoveObjectInsideView
  ✔️ Integration_SubscriptionSet_MoveObjectOutsideView
  ✔️ Integration_SubscriptionSet_WaitForSynchronization_CanBeCalledMultipleTimes
  ✔️ Integration_SubscriptionSet_WaitForSynchronization_CanBeCalledWithCancelledToken
  ✔️ Integration_SubscriptionSet_WaitForSynchronization_CanBeCancelled
  ✔️ Integration_SubscriptionWithCollections
  ✔️ Integration_SubscriptionWithEmbeddedObjects
  ✔️ Integration_SubscriptionWithLinks
  ✔️ Integration_UpdateObjectNotMatchingSubscriptions_ShouldError
  ✔️ Integration_UpdatingSubscription_SupersedesPreviousOnes
  ✔️ Integration_WaitForSynchronization_EmptyUpdate
  ✔️ Integration_WriteData_WhenOutsideOfSubscriptions_GetsRevertedByServer
  ✔️ Realm_Subscriptions_WhenDisposed_Throws
  ✔️ Realm_Subscriptions_WhenFLX_ReturnsSubscriptions
  ✔️ Realm_Subscriptions_WhenLocalRealm_Throws
  ✔️ Realm_Subscriptions_WhenPBS_Throws
  ✔️ Realm_Subscriptions_WhenSameVersion_ReturnsExistingReference
  ✔️ Realm_Subscriptions_WhenVersionIsGCed_CreatesANewOne
  ✔️ Results_Subscribe_WithCancellation_CancelsTheWait
  ✔️ Results_SubscribeNamed_FirstTimeOnly_DifferentObjectType_WaitsForChanges
  ❌ Results_SubscribeNamed_FirstTimeOnly_DifferentQuery_WaitsForChanges
	  Expected: 2
	  But was:  1
	
  ✔️ Results_SubscribeNamed_UpdateExistingFalse_WithDifferentQuery_Throws
  ✔️ Results_SubscribeNamed_UpdateExistingFalse_WithSameQuery
  ✔️ Results_SubscribeNamed_UpdatesQuery
  ✔️ Results_SubscribeNamed_WithValidQuery
  ✔️ Results_SubscribeUnnamed_WithValidQuery
  ✔️ SubscriptionSet_Add_AddsSubscription
  ✔️ SubscriptionSet_Add_ComplexQuery_AddsSubscription
  ✔️ SubscriptionSet_Add_WithoutUpdate_Throws
  ✔️ SubscriptionSet_AddSameName_DifferentType_UpdateExisting_Updates
  ✔️ SubscriptionSet_AddSameName_NoUpdate_WhenDifferentQuery_Throws
  ✔️ SubscriptionSet_AddSameName_NoUpdate_WhenDifferentType_Throws
  ✔️ SubscriptionSet_AddSameName_NoUpdate_WhenIdentical_DoesntThrow
  ✔️ SubscriptionSet_AddSameName_UpdateExisting_Updates
  ✔️ SubscriptionSet_AddSameQuery_DifferentClasses_AddsBoth
  ✔️ SubscriptionSet_AddTwice_Deduplicates
  ✔️ SubscriptionSet_AddTwice_DifferentNames_Duplicates
  ✔️ SubscriptionSet_AddTwice_NamedAndUnnamed_Duplicates
  ✔️ SubscriptionSet_Enumerator
  ✔️ SubscriptionSet_Enumerator_DoubleDispose_Throws
  ✔️ SubscriptionSet_Enumerator_Reset
  ✔️ SubscriptionSet_FindByName_Finds
  ✔️ SubscriptionSet_FindByName_ReturnsNullWhenMissing
  ✔️ SubscriptionSet_FindByQuery_Finds
  ✔️ SubscriptionSet_FindByQuery_ReturnsNullWhenMissing
  ✔️ SubscriptionSet_GetsGarbageCollected
  ✔️ SubscriptionSet_Indexer
  ✔️ SubscriptionSet_Iteration
  ✔️ SubscriptionSet_Remove_ByName
  ✔️ SubscriptionSet_Remove_ByName_OutsideUpdate_Throws
  ✔️ SubscriptionSet_Remove_ByQuery_RemoveNamed
  ✔️ SubscriptionSet_Remove_ByQuery_RemoveNamed_False
  ✔️ SubscriptionSet_Remove_Subscription
  ✔️ SubscriptionSet_Remove_Subscription_OutsideUpdate_Throws
  ✔️ SubscriptionSet_RemoveAll_RemoveNamed
  ✔️ SubscriptionSet_RemoveAll_RemoveNamed_False
  ✔️ SubscriptionSet_RemoveByType_Generic_RemoveNamed
  ✔️ SubscriptionSet_RemoveByType_Generic_RemoveNamed_False
  ✔️ SubscriptionSet_RemoveByType_RemoveNamed
  ✔️ SubscriptionSet_RemoveByType_RemoveNamed_False
  ✔️ SubscriptionSet_Update_IncrementsVersion
  ✔️ SubscriptionSet_Update_UpdatesItself
  ✔️ SubscriptionSet_Update_WhenActionThrows_RollsbackTransaction
  ✔️ SubscriptionSet_Update_WhenEmpty_Succeeds
  ✔️ SubscriptionSet_Update_WhenTransactionIsInProgress_Throws
  ✔️ SubscriptionSet_WhenParentRealmIsClosed_GetsClosed
  ✔️ SubscriptionSet_WhenSupersededParentRealmIsClosed_GetsClosed

❌ Realm.Tests.dll.Realms.Tests.Sync.FlexibleSyncTests.Results_Subscribe_Always_WaitsForChanges.

Realms.Tests.Sync.FlexibleSyncTests
  ❌ Results_Subscribe_Always_WaitsForChanges("abc")
	  Expected: 2
	  But was:  1
	
  ❌ Results_Subscribe_Always_WaitsForChanges(null)
	  Expected: 2
	  But was:  1
	

Annotations

Check failure on line -1 in No path available

See this annotation in the file changed.

@github-actions github-actions / Results Code Coverage

Realm.Tests.dll.Realms.Tests.Sync.FlexibleSyncTests. ► Realms.Tests.Sync.FlexibleSyncTests ► Results_SubscribeNamed_FirstTimeOnly_DifferentQuery_WaitsForChanges

Failed test found in:
  TestResults.Linux.xml
Error:
    Expected: 2
    But was:  1
  
Raw output
   at Realms.Tests.Sync.FlexibleSyncTests.<Results_SubscribeNamed_FirstTimeOnly_DifferentQuery_WaitsForChanges>b__77_0() in /home/runner/work/realm-dotnet/realm-dotnet/Tests/Realm.Tests/Sync/FlexibleSyncTests.cs:line 2254
   at TaskExtensions.Timeout(Task task, Int32 millisecondTimeout, Task errorTask, String detail) in /home/runner/work/realm-dotnet/realm-dotnet/Realm/Realm/Extensions/TaskExtensions.cs:line 70
   at Realms.Tests.TestHelpers.<>c__DisplayClass31_0.<<RunAsyncTest>b__0>d.MoveNext() in /home/runner/work/realm-dotnet/realm-dotnet/Tests/Realm.Tests/TestHelpers.cs:line 266
--- End of stack trace from previous location ---
   at Nito.AsyncEx.Synchronous.TaskExtensions.WaitAndUnwrapException(Task task)

Check failure on line -1 in No path available

See this annotation in the file changed.

@github-actions github-actions / Results Code Coverage

Realm.Tests.dll.Realms.Tests.Sync.FlexibleSyncTests.Results_Subscribe_Always_WaitsForChanges. ► Realms.Tests.Sync.FlexibleSyncTests ► Results_Subscribe_Always_WaitsForChanges("abc")

Failed test found in:
  TestResults.Linux.xml
Error:
    Expected: 2
    But was:  1
  
Raw output
   at Realms.Tests.Sync.FlexibleSyncTests.<>c__DisplayClass80_0.<<Results_Subscribe_Always_WaitsForChanges>b__0>d.MoveNext() in /home/runner/work/realm-dotnet/realm-dotnet/Tests/Realm.Tests/Sync/FlexibleSyncTests.cs:line 2330
--- End of stack trace from previous location ---
   at TaskExtensions.Timeout(Task task, Int32 millisecondTimeout, Task errorTask, String detail) in /home/runner/work/realm-dotnet/realm-dotnet/Realm/Realm/Extensions/TaskExtensions.cs:line 70
   at Realms.Tests.TestHelpers.<>c__DisplayClass31_0.<<RunAsyncTest>b__0>d.MoveNext() in /home/runner/work/realm-dotnet/realm-dotnet/Tests/Realm.Tests/TestHelpers.cs:line 266
--- End of stack trace from previous location ---
   at Nito.AsyncEx.Synchronous.TaskExtensions.WaitAndUnwrapException(Task task)

Check failure on line -1 in No path available

See this annotation in the file changed.

@github-actions github-actions / Results Code Coverage

Realm.Tests.dll.Realms.Tests.Sync.FlexibleSyncTests.Results_Subscribe_Always_WaitsForChanges. ► Realms.Tests.Sync.FlexibleSyncTests ► Results_Subscribe_Always_WaitsForChanges(null)

Failed test found in:
  TestResults.Linux.xml
Error:
    Expected: 2
    But was:  1
  
Raw output
   at Realms.Tests.Sync.FlexibleSyncTests.<>c__DisplayClass80_0.<<Results_Subscribe_Always_WaitsForChanges>b__0>d.MoveNext() in /home/runner/work/realm-dotnet/realm-dotnet/Tests/Realm.Tests/Sync/FlexibleSyncTests.cs:line 2330
--- End of stack trace from previous location ---
   at TaskExtensions.Timeout(Task task, Int32 millisecondTimeout, Task errorTask, String detail) in /home/runner/work/realm-dotnet/realm-dotnet/Realm/Realm/Extensions/TaskExtensions.cs:line 70
   at Realms.Tests.TestHelpers.<>c__DisplayClass31_0.<<RunAsyncTest>b__0>d.MoveNext() in /home/runner/work/realm-dotnet/realm-dotnet/Tests/Realm.Tests/TestHelpers.cs:line 266
--- End of stack trace from previous location ---
   at Nito.AsyncEx.Synchronous.TaskExtensions.WaitAndUnwrapException(Task task)