Added RetryCustomConfirmationAsync #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papafe
commented
Nov 3, 2023
| @@ -92,6 +92,8 @@ public static void RunBaasTestAsync(Func<Task> testFunc, int timeout = 30000) | |||
|
|
|||
| public static string GetVerifiedUsername() => $"realm_tests_do_autoverify-{Guid.NewGuid()}"; | |||
|
|
|||
| public static string GetUnconfirmedUsername() => $"realm_tests_do_not_confirm-{Guid.NewGuid()}@g.it"; | |||
There was a problem hiding this comment.
RetryCustomConfirmation will fail if the input doesn't look like a proper email. We could add the same to GetVerifiedUsername for consistency
papafe
commented
Nov 3, 2023
| { | ||
| let newVal = { | ||
| 'email': username, | ||
| 'token': token, |
There was a problem hiding this comment.
Saving the token and tokenId is not necessary now, but it could be useful if we want to write tests for ConfirmAsync
Pull Request Test Coverage Report for Build 6743724741
💛 - Coveralls |
nirinchev
approved these changes
Nov 3, 2023
| // At the same time we save the user email in a collection. | ||
| await DefaultApp.EmailPasswordAuth.RegisterUserAsync(unconfirmedMail, SyncTestHelpers.DefaultPassword).Timeout(10_000, detail: "Failed to register user"); | ||
|
|
||
| var ex3 = await TestHelpers.AssertThrows<AppException>(() => DefaultApp.LogInAsync(credentials)); |
There was a problem hiding this comment.
Not super important, but why is this ex3 rather than just ex?
There was a problem hiding this comment.
Because before I had the sections in the opposite order and I forgot to rename the exceptions 😁
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3463
TODO