Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI builds #3484

Merged
merged 10 commits into from
Dec 6, 2023
Merged

Fix CI builds #3484

merged 10 commits into from
Dec 6, 2023

Conversation

nirinchev
Copy link
Member

Description

Fixes #

TODO

  • Changelog entry
  • Tests (if applicable)

@nirinchev nirinchev added the no-changelog Used to skip the changelog check label Nov 29, 2023
@nirinchev nirinchev requested a review from papafe November 29, 2023 16:46
papafe
papafe approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I suppose we'll use .NET 7.0 for the time being?

@nirinchev
Copy link
Member Author

Yeah. Eventually, we can move off net6 when support ends.

@nirinchev nirinchev marked this pull request as ready for review December 6, 2023 20:50
@nirinchev nirinchev merged commit b7db4cb into main Dec 6, 2023
66 of 68 checks passed
@nirinchev nirinchev deleted the ni/fix-ci branch December 6, 2023 20:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe papafe approved these changes

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees

@nirinchev nirinchev

Labels
no-changelog Used to skip the changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirinchev @fealebenpae @papafe