Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNET-1092] Added support for indexed RealmValue #3544

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Mar 6, 2024

Fixes #3493

TODO

  • Changelog entry
  • Tests (if applicable)

Copy link

coveralls-official bot commented Mar 6, 2024

Pull Request Test Coverage Report for Build 8175476881

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 81.001%

Totals Coverage Status
Change from base Build 8172453424: 0.002%
Covered Lines: 6790
Relevant Lines: 8233

💛 - Coveralls

@papafe papafe requested a review from nirinchev March 7, 2024 12:43
@papafe papafe marked this pull request as ready for review March 7, 2024 12:43
# Conflicts:
#	.github/workflows/test-net-core.yml
@papafe papafe merged commit 0d40c41 into fp/mixed-collections Mar 7, 2024
44 of 47 checks passed
@papafe papafe deleted the fp/indexed-realmvalue branch March 7, 2024 13:06
papafe added a commit that referenced this pull request Mar 7, 2024
* Added stub

* Stubs with comments

* Notes

* Various fixes

* Updated core

* Finished stub

* Removed comment [skip-ci]

* Removed unused

* Added stub for lists in lists

* Fixed error with null and added basic test with all types

* Improved base testing for list, added support for add/insert/set and equality checking

* Improved test and removed useless content

* Added tests

* Small fixes

* Small fixes

* Added common method for creating a list and adding elements

* Fixed error [skip-ci]

* Added set and dictionary to primitive value

* Various improvements

* Added conversion per list

* Fixed Operator

* Added missing conversion methods

* Corrected wrapper

* Added test helper method for realm value types and removed unused reflextion extension method

* Added missing types for marshaling

* Small improvement in operator

* Small corrections

* Added error for sets adding collections

* Trting to uniform access

* Created common method for collections

* Various improvements [skip-ci]

* Fixed dictionary and added more tests

* Small corrections

* Improved tests for dictionaries

* Small fixes

* Simplified set collection on object

* Added test for dynamic and simplified collection generation

* Updated db

* Updated changelog [skip-ci]

* Updated another db

* Updated db

* Updated changelog

* Test

* Fix to generated files

* Test

* Small improvement

* Added field offset

* Working version

* Small renaming

* Reordering

* Working version

* Solution 1

* Final version of the RealmValue explicit layout

* Added changelog

* Removed set from RealmValue

* Continuing removal of set

* Simplified CreateInternalCollectionAndPopulate

* Ulterior removal of set and added method parameter name

* Removed other set-related things, added implicit method from array of RealmValue

* Changed name to method

* Added explicit sequence equals

* Unified set_collection and add_collection for dictionary

* Moved _intValue out of primitiveValue

* Removed unnecessary structs

* Changed return value

* Small corrections

* Fixed changelog

* Updated core and a couple of fixes

* Small corrections

* Updated dbs

* Updated core to 14.0.1 and changelog

* Added test for collection indexes

* Updated changelog

* Fixed realm studio version

* Updated guids to v24

* Corrected methods

* Corrected changelog and wrapper

* Added comments

* Corrected changelog

* Corrected changelog

* Updated core

* Updated changelog

* Used correct core version

* Fixed changelog

* Fixed changelog

* Added missing tests

* Fixed tests

* [RNET-1092] Added support for indexed RealmValue (#3544)

* Added support for indexed RealmValue

* Fixed changelog

* Corrected indexable property types in schema

* Added missing newline in the changelog

* Testing fix for CI
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants