RNET-1154, RNET-1151, RNET-1139: Compact-related fixes #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
commented
Jun 6, 2024
Comment on lines
-52
to
-61
| /// <summary> | ||
| /// A callback, invoked when opening a Realm for the first time during the life | ||
| /// of a process to determine if it should be compacted before being returned | ||
| /// to the user. | ||
| /// </summary> | ||
| /// <param name="totalBytes">Total file size (data + free space).</param> | ||
| /// <param name="bytesUsed">Total data size.</param> | ||
| /// <returns><c>true</c> to indicate that an attempt to compact the file should be made.</returns> | ||
| /// <remarks>The compaction will be skipped if another process is accessing it.</remarks> | ||
| public delegate bool ShouldCompactDelegate(ulong totalBytes, ulong bytesUsed); |
There was a problem hiding this comment.
these are moved to RealmConfigurationBase so they become available to sync configs.
| @@ -321,50 +321,6 @@ public void RealmObjectClassesOnlyAllowRealmObjects() | |||
| Assert.That(ex.Message, Does.Contain("must descend directly from either RealmObject, EmbeddedObject, or AsymmetricObject")); | |||
| } | |||
|
|
|||
| [TestCase(true)] | |||
| [TestCase(false)] | |||
| public void ShouldCompact_IsInvokedAfterOpening(bool shouldCompact) | |||
There was a problem hiding this comment.
This is moved to SynchronizedInstanceTests.
| @@ -463,6 +419,32 @@ public void Compact_WhenResultsAreOpen_ShouldReturnFalse() | |||
| token.Dispose(); | |||
| } | |||
|
|
|||
| [Test] | |||
| public void Compact_WhenShouldDeleteIfMigrationNeeded_PreservesObjects() | |||
Pull Request Test Coverage Report for Build 9396984287Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3617
Fixes #3583
Fixes #3612
TODO