Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ReconnectBackoffOptions on SyncTimeoutOptions #3661

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Expose ReconnectBackoffOptions on SyncTimeoutOptions #3661

merged 5 commits into from
Aug 23, 2024

Conversation

fealebenpae
Copy link
Member

Description

Fixes #

TODO

  • Changelog entry
  • Tests

@fealebenpae fealebenpae requested a review from nirinchev August 21, 2024 22:52
@fealebenpae fealebenpae self-assigned this Aug 21, 2024
@cla-bot cla-bot bot added the cla: yes label Aug 21, 2024
nirinchev
nirinchev approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just suppress those warnings though.

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Aug 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10525776643

Details

  • 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 81.524%
Totals Coverage Status
Change from base Build 10525701120: 0.03%
Covered Lines: 6923
Relevant Lines: 8337
💛 - Coveralls

@fealebenpae fealebenpae merged commit b73263e into main Aug 23, 2024
67 of 73 checks passed
@fealebenpae fealebenpae deleted the yg/reconnect-delay-options branch August 23, 2024 13:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

Assignees

@fealebenpae fealebenpae

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fealebenpae @nirinchev