No analytics in production

[kneth]

What, How & Why?

The environment variable NODE_ENV is today commonly used by many JavaScript framework. We can use the variable to disable analytics for test and production stages.

NODE_ENV is set or used by:

• Jest ("test") - https://jestjs.io/docs/environment-variables
• Express ("production") - https://expressjs.com/en/advanced/best-practice-performance.html#set-node_env-to-production
• Webpack ("production") - https://jestjs.io/docs/environment-variables
• React ("development", "test", "production") - https://create-react-app.dev/docs/adding-custom-environment-variables/
• pm2 ("production") - https://pm2.keymetrics.io/docs/usage/environment/

NODE_ENV is not set by:

• Mocha - Would be nice if mocha sets the NODE_ENV variable to 'test' mochajs/mocha#185
• Jasmine
• rollup (but mentioned in documentation)
• nodemon - configure NODE_ENV variable when starting node server remy/nodemon#184

☑️ ToDos

• 📝 Changelog entry
• [ ] 📝 Compatibility label is updated or copied from previous entry
• [ ] 🚦 Tests
• [ ] 📝 Public documentation PR created or is not necessary
• [ ] 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

• [ ] typescript definitions file is updated
• [ ] jsdoc files updated
• [ ] Chrome debug API is updated if API is available on React Native

[nirinchev]

Is this going to work with Electron? I believe the suggestion there is to use app.isPackaged, but not sure if it also sets NODE_ENV.

[kneth]

Is this going to work with Electron? I believe the suggestion there is to use app.isPackaged, but not sure if it also sets NODE_ENV.

Electron is often used with a JavaScript framework (React, maybe) which will cover many cases. The documentation is hinting that app.isPackaged doesn't guarantee that you can detect development or production stage. Still, it might be the best we can do for now.

[fronck]

LGTM 👍