[v6] Disable analytics: CI and production environments

CHANGELOG.md

@@ -4,7 +4,6 @@ x.x.x Release notes (yyyy-MM-dd)
 * None.
 
 ### Fixed
-* <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-js/issues/????), since v?.?.?)
 * None.
 
 ### Compatibility
@@ -13,7 +12,8 @@ x.x.x Release notes (yyyy-MM-dd)
 * File format: Generates Realms with format v11 (reads and upgrades previous file format).
 
 ### Internal
-* None.
+* Disable analytics if `NODE_ENV` is set to `"production"` or `"test"`. Since `NODE_ENV` is used by many commonly used JavaScript frameworks, this should help us to get a better signal-to-noise ratio in our builders' statistics.
+* Disable analytics if the `CI` environment variable is set to some value.
 
 6.1.7 Release notes (2021-3-13)
 =============================================================

lib/submit-analytics.js

@@ -107,7 +107,21 @@ class MixpanelDetails {
 
 
 function isAnalyticsDisabled() {
-    return 'REALM_DISABLE_ANALYTICS' in process.env;
+    // NODE_ENV is commonly used by JavaScript framework
+    if ("NODE_ENV" in process.env) {
+        return process.env["NODE_ENV"] === "production" || process.env["NODE_ENV"] === "test";
+    }
+
+    // Electron apps are assumed to be in production if packaged
+    try {
+        const { app } = require("electron");
+        return !app.isPackaged;
+    } catch (_) {
+        // ignore error
+    }
+
+    // If the user has specifically opted-out or if we're running in a CI environment
+    return 'REALM_DISABLE_ANALYTICS' in process.env || "CI" in process.env;
 }
 
 function sha256(data) {

react-native/android/analytics_template

@@ -57,8 +57,9 @@ class SendAnalyticsTask extends DefaultTask {
     def sendAnalytics() {
        try {
             def env = System.getenv()
-            def disableAnalytics= env['REALM_DISABLE_ANALYTICS']
-            if (disableAnalytics == null || disableAnalytics != "true") {
+            def disableAnalytics = env['REALM_DISABLE_ANALYTICS'] != null
+            def isCI = env['CI'] != null
+            if (!disableAnalytics && !isCI) {
                 send()
             }
        } catch(all) {}

react-native/ios/RealmReact/RealmAnalytics.mm

@@ -220,7 +220,7 @@ static bool RLMIsDebuggerAttached() {
 }
 
 void RLMSendAnalytics() {
-    if (getenv("REALM_DISABLE_ANALYTICS") || !RLMIsDebuggerAttached()) {
+    if (getenv("REALM_DISABLE_ANALYTICS") || getenv("CI") || !RLMIsDebuggerAttached()) {
         return;
     }