Fix return type of App.allUsers
#5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elle-j
commented
Apr 5, 2023
Comment on lines
220
to
227
| public get allUsers(): Readonly<Record<string, User<FunctionsFactoryType, CustomDataType>>> { | ||
| const result: Record<string, User<FunctionsFactoryType, CustomDataType>> = {}; | ||
| for (const user of this.internal.allUsers) { | ||
| result[user.identity] = User.get(user); | ||
| } | ||
|
|
||
| return result; | ||
| } |
There was a problem hiding this comment.
Note: realm-web uses Object.fromEntries(). Feel free to comment on what is preferred here.
There was a problem hiding this comment.
Lol - I just saw this now 🤦 If I have to choose, I probably like fromEntries because it's shorter (fewer lines and doesn't need the type declared on result) and I generally like a pure function over iterating and mutating an object (the result in this case).
There was a problem hiding this comment.
Gotcha, despite the extra iteration from needing to create the array (.map) passed to fromEntries?
kraenhansen
reviewed
Apr 5, 2023
kraenhansen
approved these changes
Apr 5, 2023
kraenhansen
approved these changes
Apr 5, 2023
papafe
added a commit
that referenced
this pull request
Apr 13, 2023
* main: (41 commits) allow useQuery to filter or sort a collection by using a callback (#5513) Fix `realm.create` types and 'requiredProperties' on Realm.Object constructor (#5697) Fix return type of `App.allUsers` (#5708) Removed renamed file Remove console.log Fix README instructions and bump version Bump template versions Update Templates (#5702) Moved "submodules" wireit task to "postinstall" Set up typedoc for realm-react, realm-web (#5709) Prepare for vNext (#5711) Prepare for 12.0.0-alpha.2 (#5707) Build iOS prebuilds in release by default (#5710) Use the event.sender as assignee when preparing release Updated prepare release workflow to print PR url in summary Fixing lint error fix the template app links (#5701) Expose `Sync` as named export (#5705) Enable all tests after bad rebase (#5595) Clear test state flag (#5689) ... # Conflicts: # packages/realm/src/Realm.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
App.allUserswas returning an array of users but now returns a record with theUser.idas the key and theUseras the value as the intended type.This closes #5671.
☑️ ToDos