-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing Realm Swift's Error type to just be a typealias for RLMError #3835
Conversation
bbc2e00
to
b117b77
Compare
+1 Will Jazzy still generate Swift documentation for |
Ugh. Good question, let me try regenerating the docs and see what happens. |
I wasn't able to get Jazzy working with Xcode 8, but I do know what happens: we won't get the per-case documentation for |
Aw, that definitely sucks. It's still probably a good move to consolidate these types though, so still +1 from me. |
How difficult would it be to extend Jazzy so that "exported" classes also generate documentation? @jpsim |
b117b77
to
8093b92
Compare
I think what I'm going to do is as follows:
This is sort of like how the Would anyone have any objections to this? |
8093b92
to
f679314
Compare
How does this change interact with the NSError bridging changes in Swift 3? Does this change limit what sort of information we can include with errors in the future (since |
Jazzy doesn't document inherited members, which also includes typealiases. See |
@jpsim Wrong issue number? |
Right issue number, wrong repo: realm/jazzy#190 |
Superseded by #3934, which also debated this issue (and decided it wasn't worth the trouble to implement). |
There's no real good reason to have
Error
in Realm Swift be its own separate enum. Having an==
for non-specificErrorProtocol
instances is also kind of problematic.@tgoyne @jpsim @bdash @JadenGeller