Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging #11

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Improve logging #11

merged 6 commits into from
Jun 10, 2024

Conversation

realshouzy
Copy link
Owner

  • Improve the error message to be more consistent with pip
  • Use logging.config.dictConfig
  • Move logger instance inside main
  • Rename _StdOutFilter to _NonErrorFilter

@realshouzy
Improve logging
4a57dbb 
- Use logging.config.dictConfi
- Make error message more similar to pip
@realshouzy
Futher improve logging
d0bce10 
- Move logger instance inside main
- Rename _StdOutFilter to _NonErrorFilter
- Improve dictConfig
- Use hexadecimal escape sequences
@realshouzy
Adjust tests for new logging
f062889
@realshouzy
Fix testing fails
6553516
@realshouzy
Mark retain_pytest_handlers as in internal
fea92e4
@realshouzy
Update pragam
6635adc
@realshouzy realshouzy marked this pull request as ready for review June 10, 2024 23:27
@realshouzy realshouzy merged commit c83325a into main Jun 10, 2024
29 checks passed
@realshouzy realshouzy deleted the improve-logging branch June 10, 2024 23:28
@realshouzy realshouzy added the enhancement New feature or request label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@realshouzy