Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(shellcheck): check all shell scripts recursively (#433) #436

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

tiborsimko
Copy link
Member

No description provided.

Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the PR number in the commit message should be 436 and not 433

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (687f2f4) 37.66% compared to head (709a685) 37.66%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   37.66%   37.66%           
=======================================
  Files          26       26           
  Lines        1561     1561           
=======================================
  Hits          588      588           
  Misses        973      973           

@tiborsimko tiborsimko merged commit 709a685 into reanahub:master Jan 12, 2024
17 checks passed
@tiborsimko tiborsimko deleted the commitlint branch January 12, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants