Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system: Introduce Kueue as an optional alternative approach how to submit user jobs #453

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

xaviertintin
Copy link

@xaviertintin xaviertintin commented May 15, 2024

This pull request introduces changes to the reana-job-controller component to enable Kueue as an optional job submission method in REANA, working in conjunction with the previously submitted changes to reana-workflow-controller.

Key Changes:

  1. Environment Variable Access:
  • Retrieves the KUEUE_ENABLED environment variable within reana-job-controller/reana_job_controller/config.py. This variable reflects the admin's selection of Kueue during deployment via Helm values.
  1. Deployment Type Selection:
  • Based on the retrieved environment variable, the code in reana-job-controller/reana_job_controller/kubernetes_job_manager.py dynamically selects the appropriate job submission method:
    • Standard: If KUEUE_ENABLED is False, the existing Kubernetes Job API is used for job submission.
    • Kueue: If KUEUE_ENABLED is True, the pull request implements the necessary logic to utilize Kueue for job submission.

Benefits:

  • Aligns reana-job-controller with the changes in reana-workflow-controller to enable Kueue as an optional job submission method.
  • Ensures that the chosen job submission approach (standard or Kueue) is reflected in the actual job execution handled by reana-job-controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant