ui: make details available for shared workflows #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Nice job! Just wanted to highlight that before merging, the design of the badges (notebook icon / shared icon and popup, and the others) will probably change (look at the discussion in #321), but we should talk about this IRL.
| <div | ||
| className={className || styles.container} | ||
| style={ | ||
| insideClickableElement ? { cursor: "pointer" } : { cursor: "default" } |
There was a problem hiding this comment.
Why is this needed? Also, maybe we can just conditionally render the action menu if workflow.owner_email === "-", WDYT?
DaanRosendal
force-pushed
the
shared-workflow-details
branch
3 times, most recently
from
121f8d2
to
3e4fa44
Compare
This was referenced Aug 20, 2024
mdonadoni
force-pushed
the
shared-workflow-details
branch
from
3e4fa44
to
ab22164
Compare
|
Latest version before rebase: 3e4fa44 There are still many comments to address from older PRs
|
mdonadoni
added a commit
to DaanRosendal/reana-ui
that referenced
this pull request
Aug 29, 2024
|
Ready to be reviewed, squashed and merged |
tiborsimko
force-pushed
the
shared-workflow-details
branch
from
54c870f
to
83eee02
Compare
tiborsimko
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana-server#651