feat(helm): add value to customise URL of privacy notice (#778) #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #778 +/- ##
=======================================
Coverage 18.61% 18.61%
=======================================
Files 26 26
Lines 2326 2326
=======================================
Hits 433 433
Misses 1893 1893 |
mdonadoni
force-pushed
the
privacy-notice-link
branch
from
fe1ce0e
to
650ddbd
Compare
| @@ -12,9 +15,9 @@ data: | |||
| client_pyvenv: {{ .Values.components.reana_ui.client_pyvenv | quote | default "null" }} | |||
| forum_url: {{ .Values.components.reana_ui.forum_url | quote | default "null" }} | |||
There was a problem hiding this comment.
If we update the default value for the forum and docs URLs in the README, shouldn't we update them here as well?
There was a problem hiding this comment.
They are already set in the values file, I am just keeping the docs up to date:
Lines 76 to 77 in 79aedb9
giuseppe-steduto
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana-ui#392