Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout #255

Closed
wants to merge 51 commits into from
Closed

Layout #255

wants to merge 51 commits into from

Conversation

dtclinch
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reagraph ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 7:52am

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit c02e0bb
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/66a2040a131c200008ed4164
😎 Deploy Preview https://deploy-preview-255--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl
Copy link
Member

amcdnl commented Jul 25, 2024

@dtclinch - This looks interesting - happy to accept a pr

@@ -63,10 +63,17 @@ export const useDrag = ({
},
onDrag: ({ event }) => {
// Compute normalized mouse coordinates (screen space)
const scrollX = window.scrollX || window.pageXOffset;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghsteff - 👀

@@ -11,10 +11,16 @@ export interface Theme {
opacity: number;
selectedOpacity: number;
inactiveOpacity: number;
showRing?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you pass null to the node for the ring, it will hide it.

@@ -227,7 +227,7 @@ export const Edges: FC<EdgesProps> = ({
<a.meshBasicMaterial
attach="material-0"
color={theme.edge.fill}
depthTest={false}
depthTest={true}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why this changed

import { Color, ColorRepresentation, Euler } from 'three';
import ellipsize from 'ellipsize';
import { a } from '@react-spring/three';

const calculateTextSize = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtclinch
Copy link
Author

@amcdnl My apologies, it was raised by mistake, currently a lot of things are under experiments and testing phase, we are trying to add features like Zoomcharts network graphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants