Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed labelType none still shows label when hovering over node #265

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

dtsuper3
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reagraph ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 7:18pm

Copy link

netlify bot commented Aug 10, 2024

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit 5efd5ec
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/66b7bcc671d4a600089b0605
😎 Deploy Preview https://deploy-preview-265--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -306,6 +306,7 @@ export const Node: FC<NodeProps> = ({

const labelComponent = useMemo(
() =>
labelVisible &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghsteff - can u confirm this change won't regress any of the other features we added?

Copy link
Contributor

@ghsteff ghsteff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@amcdnl amcdnl merged commit 4a47808 into reaviz:master Aug 19, 2024
5 of 6 checks passed
@Obaydahm
Copy link

Obaydahm commented Aug 20, 2024

@ghsteff @amcdnl is it possible to publish a new version that includes these changes? I can see that the latest version is 2 months old. Thanks in advance!

@ghsteff
Copy link
Contributor

ghsteff commented Aug 20, 2024

@Obaydahm yep! Released in 4.19.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants