Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - SD Prompt Saver node fails to save in jpg and webp formats #10

Closed
Dachiko opened this issue Oct 28, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@Dachiko
Copy link

Dachiko commented Oct 28, 2023

Description

Selecting any other format aside from png results in error (png works just fine) (latest build):

Error occurred when executing SDPromptSaver:

[Errno 2] No such file or directory: '00001.webp'

File "C:\Stable Diffusion\GUIs\ComfyUI_windows_portable\ComfyUI\execution.py", line 153, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Stable Diffusion\GUIs\ComfyUI_windows_portable\ComfyUI\execution.py", line 83, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Stable Diffusion\GUIs\ComfyUI_windows_portable\ComfyUI\execution.py", line 76, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Stable Diffusion\GUIs\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-prompt-reader-node\nodes.py", line 386, in save_images
piexif.insert(metadata, str(file))
File "C:\Stable Diffusion\GUIs\ComfyUI_windows_portable\python_embeded\Lib\site-packages\piexif_insert.py", line 32, in insert
with open(image, 'rb') as f:
^^^^^^^^^^^^^^^^^

Reproduction steps

  1. Image generated
  2. SD Prompt Saver node fails to save an image with jpg or webp format selected

Image file

No response

Version

1.0.0

@Dachiko Dachiko added the bug Something isn't working label Oct 28, 2023
receyuki added a commit that referenced this issue Oct 31, 2023
@receyuki
Copy link
Owner

Fixed in v1.0.1, please update the node to the latest version.

@receyuki receyuki closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants