Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Prompt Merger producing unsanitised output with concatenated NULL strings. #29

Closed
RangerFrank opened this issue Dec 4, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@RangerFrank
Copy link

Description

SDPromptMerger throws an error when fed empty strings

Error occurred when executing SDPromptMerger:

list index out of range

File "D:\AI\ComfyUI_windows_portable\ComfyUI\execution.py", line 143, in recursive_execute
input_data_all = get_input_data(inputs, class_def, unique_id, outputs, prompt, extra_data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI_windows_portable\ComfyUI\execution.py", line 27, in get_input_data
obj = outputs[input_unique_id][output_index]
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^

Reproduction steps

image

Image file

No response

@RangerFrank RangerFrank added the bug Something isn't working label Dec 4, 2023
@RangerFrank
Copy link
Author

To clarify, Show Text accepts the null string value from the prompt, but not a concatenated null string from SD Prompt Merger. I think this is an output formatting issue rather than a problem with pysssss, though there should probably be some input sanitation over there too.

@RangerFrank RangerFrank changed the title [BUG] - SDPromptMerger throws an error when fed empty strings [BUG] - Pysssss throws an error when fed empty concatenated strings from Prompt Merger Dec 4, 2023
@RangerFrank
Copy link
Author

RangerFrank commented Dec 4, 2023

Here's the Prompt Merger error from my main workflow

image

This occurs when prompt merger is fed two empty concatenated strings from two other instances of Prompt Merger.

image

@RangerFrank RangerFrank changed the title [BUG] - Pysssss throws an error when fed empty concatenated strings from Prompt Merger [BUG] - Prompt Merger producing unsanitised output with concatenated NULL strings. Dec 4, 2023
@receyuki
Copy link
Owner

receyuki commented Dec 6, 2023

Would you mind sending me this part of the workflow? I can't reproduce this issue with my custom nodes.

@receyuki
Copy link
Owner

receyuki commented Dec 6, 2023

Oh, I get it, you are using two empty primitive nodes. I will fix this issue in the next version.

receyuki added a commit that referenced this issue Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants