-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate .options changes when SwiftUI View is updated #697
Comments
If you find useful, I can create a PR from my fork https://github.com/nfgrilo/Parchment/tree/4.0 |
Thank you so much for the detailed issue and fix! I really appreciate it 🙌 The patches you provided look great. Feel free to create a PR from your fork, although we can probably skip the DefaultView changes. |
nfgrilo
added a commit
to nfgrilo/Parchment
that referenced
this issue
Feb 17, 2024
Thanks! I've created a PR with a single commit here: #703 Great work ❤️ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4.0
Currently, when the
View
holding thePageView
has changes and need refresh,PageView
modifiers changes are not propagated to UIKit (but SwiftUI contents insidePage
are 👍🏼).My use case is that I support custom themes on my app, and everything is correctly updated except for the menu items.
I have attached three patches (
4.0
branch):DefaultView
on ExampleSwiftUI target).options
viaPagingControllerRepresentableView.updateUIViewController()
.indicatorStyle()
modifier (after propagatingoptions
)0001-Added-changes-to-DefaultView-to-exemplify.patch
0002-Propagate-.options-modifiers-on-View-updates.patch
0003-Fixed-.indicatorStyle-not-being-respected.patch
I would be very grateful if you could give a try and have a look!
The text was updated successfully, but these errors were encountered: