Safely unwrap selectedViewController before calling the delegate methods
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if let selectedViewController = selectedViewController, | ||
| self.navigationDirection == .reverse { // check if direction changed | ||
| self.didFinishScrolling(to: selectedViewController) | ||
| self.willScroll(from: selectedViewController, to: self.afterViewController!) |
There was a problem hiding this comment.
Should afterViewController and beforeViewController also be safely unwrapped?
There was a problem hiding this comment.
I thought about that, but then there are about 40 instances of force unwrapping in this file and I figured it would be smarter to only if I only changed what's needed instead of fixing everything and potentially breaking something accidentally.
|
Thank you so much for doing this – I really appreciate it 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #225
Ideally,
scrollViewDidScroll(_:) probably just shouldn't be called ifselectedViewController` is nil. But since that code is from another, less maintained repo, this is a quick fix to prevent force-unwrapping crashes.