Fix regression causing menuInteraction property not to work properly #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #485
The behavior of
menuInteraction = .swipe // or .none
requirescollectionView.isScrollEnabled = false
.But the
menuInteraction
changes call theconfigureMenuInteraction()
directly and pass through thecollectionView.isScrollEnabled = false
setting.Parchment/Parchment/Classes/PagingViewController.swift
Lines 69 to 74 in e0dc31a
Parchment/Parchment/Classes/PagingController.swift
Lines 25 to 29 in e0dc31a
Parchment/Parchment/Classes/PagingController.swift
Lines 317 to 320 in e0dc31a
Parchment/Parchment/Classes/PagingController.swift
Lines 332 to 363 in e0dc31a
I move the collectionView's setting codes and add a swipe animation based on ver1.7.0 implements.
Parchment/Parchment/Classes/PagingViewController.swift
Lines 624 to 645 in 952db5d
Parchment/Parchment/Classes/PagingViewController.swift
Line 683 in 952db5d