Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with unsafe flags when using SwiftPM #662

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

rechsteiner
Copy link
Owner

In #615, -weak_framework SwiftUI was added as an unsafe compiler flag to the Swift package and Xcode project. This fixed an issue where you could not use Parchment on platforms that did not support SwiftUI. It turned out that this causes another issue where users cannot install Parchment using SwiftPM (reproducible by creating a new Xcode project with the SwiftUI template).

Removing this will probably bring back the other issue, but most people have started updating to iOS versions that support SwiftUI now. People still using older iOS version would have to target version 3.2.0, but that is probably fine as the majority of new features are likely to be SwiftUI improvements anyway.

In #615, -weak_framework SwiftUI was added as an unsafe compiler flag
to the Swift package and Xcode project. This fixed an issue where you
could not use Parchment on platforms that did not support SwiftUI. It
turned out that this causes another issue where users cannot install
Parchment using SwiftPM (reproducible by creating a new Xcode project
with the SwiftUI template).

Removing this will probably bring back the other issue, but most
people have started updating to iOS versions that support SwiftUI
now. People still using older iOS version would have to target version
3.2.0, but that is probably fine as the majority of new features are
likely to be SwiftUI improvements anyway.
@rechsteiner rechsteiner merged commit 0d3fe86 into main Mar 7, 2023
@rechsteiner rechsteiner deleted the remove-unsafe-flags branch March 7, 2023 21:31
@Wei18
Copy link

Wei18 commented Mar 8, 2023

Maybe you can consider split SwiftUI and UIKit into 2 swift package library~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants