Constrain menu to safe area insets by default #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the menu is shown below the navigation bar by default. This could potentially break apps that expect this to be constrained to the top of the view, and they would need to provide their own PagingView subclass that overrides the constraints.
rechsteiner
added a commit
that referenced
this pull request
Apr 6, 2023
In #668, the logic for menuPosition was removed by accident. This brings it back and fixes some auto layout warnings.
rechsteiner
added a commit
that referenced
this pull request
Apr 6, 2023
In #668, the logic for menuPosition was removed by accident. This brings it back and fixes some auto layout warnings.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the menu is shown below the navigation bar by default. This could potentially break apps that expect this to be constrained to the top of the view, and they would need to provide their own PagingView subclass that overrides the constraints.