Fix rotation and crash issues with calling layoutIfNeeded #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling layoutIfNeeded when laying out the page view sometimes caused apps to crash when this was done while hidden. It also does not work when rotating the device while another view is pushing.
When rotating the device while pushing another view, the menu would be messed up when navigating back to this view.
This was referenced Apr 7, 2023
mlee-finyard
pushed a commit
to finyard/Parchment
that referenced
this pull request
May 22, 2024
Fix rotation and crash issues with calling layoutIfNeeded
mlee-finyard
added a commit
to finyard/Parchment
that referenced
this pull request
May 22, 2024
Merge pull request rechsteiner#680 from rechsteiner/fix-layout-issues
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling layoutIfNeeded when laying out the page view sometimes caused
apps to crash when this was done while hidden. It also does not work
when rotating the device while another view is pushing.