New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Misleading Example provided in LibffmConverter #1577

Closed

tim5go opened this issue Dec 10, 2021 · 1 comment

tim5go commented Dec 10, 2021

The example provided in LibffmConverter is wrong
https://github.com/microsoft/recommenders/blob/27709229cdc4aa7d39ab715789f093a2d21d2661/recommenders/datasets/pandas_df_utils.py#L134-L141

The expected output for last column should be:

field4 
4:6:1 
4:7:1 
4:8:1 
4:9:1
4:10:1

miguelgfierro mentioned this issue

[BUG] in LibffmConverter docstrings #1589

Merged

4 tasks

Collaborator

miguelgfierro commented Dec 17, 2021

thanks @tim5go for reporting this, PR sent

miguelgfierro closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment