Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] in LibffmConverter docstrings #1589

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

miguelgfierro
Copy link
Collaborator

Description

fix #1577

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@codecov-commenter
Copy link

Codecov Report

Merging #1589 (9cf8d82) into staging (7013f0d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1589      +/-   ##
===========================================
+ Coverage    61.88%   61.90%   +0.01%     
===========================================
  Files           84       84              
  Lines         8458     8462       +4     
===========================================
+ Hits          5234     5238       +4     
  Misses        3224     3224              
Flag Coverage Δ
pr-gate 61.90% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recommenders/datasets/pandas_df_utils.py 94.89% <ø> (ø)
recommenders/models/rbm/rbm.py 73.66% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45195d3...9cf8d82. Read the comment docs.

@miguelgfierro
Copy link
Collaborator Author

FYI @anargyri

@miguelgfierro miguelgfierro merged commit 1932d2a into staging Jan 17, 2022
@miguelgfierro miguelgfierro deleted the miguel/libffmconverter branch January 17, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants