-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cheetm/lightfm_deep_dive #1096
cheetm/lightfm_deep_dive #1096
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
@cheetm this looks really good, I added some comments. It would be great if you could connect with Nile, she has already a lot of experience on the repo |
@niwilso I'm trying to add you as reviewer but for some reason I can't. Feel free to add comments and suggestions as well |
…menders into cheetm/add_lightfm_deepdive
…menders into cheetm/add_lightfm_deepdive
Hey @cheetm this PR is very nice. Thanks for the great work! |
Hi @anargyri thanks for your comments. You can use the output from cell 18 and/or cell 32 for comparison with other algorithms. Hope thats okay. |
@cheetm about this:
FYI @yueguoguo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really good job
I have added section 3.6 to demonstrate the difference (albeit very naively), the difference is so great I don't think we need to resort to timeit. I haven't got time to properly investigate your second point, but I am guessing if you have already fitted the latent matrices, the scores can be retrieved much more efficiently all at once instead of individually. |
Description
Added LightFM deep dive with accompanying utils
Related Issues
#1097
Checklist:
staging
and notmaster
.