-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing anaconda link in dockerfile #1120
Conversation
docker/Dockerfile
Outdated
@@ -90,7 +90,6 @@ WORKDIR ${HOME} | |||
COPY --from=base ${HOME} . | |||
|
|||
# Setup Conda environment | |||
ENV PATH="${HOME}/conda/bin:${PATH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change happend python: not found
error when I built full environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. We need this line after since I'm pulling from Nvidia base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is not about #1120, but docker build still failed at the following problem. I faced this problem before when I built environment without docker. It seems to install cmake, but I don't know why this error happend. If this problem should not be handled in this PR, Please ignore.
|
hmm, odd. yeah. do you mind creating a separate issue for this? |
Description
Fix anaconda link in Dockerfile
Related Issues
#1116
Checklist:
staging
and notmaster
.