Change package name to underscore

[miguelgfierro]

Description

Change package name to underscore so both wheel and tar.gz has the same pattern:

ms_recommenders-0.6.0.post1623931532-py3-none-manylinux1_x86_64.whl  
ms_recommenders-0.6.0.post1623931532.tar.gz

Related Issues

Checklist:

• I have followed the contribution guidelines and code style for this project.
• I have added tests covering my contributions.
• I have updated the documentation accordingly.
• This PR is being made to staging branch and not to main branch.

[wutaomsft]

If scikit-learn does what we have been doing, is there a need for this change?

[gramhagen]

i agree, using hyphens in the package name and underscores in the import is not unusual. i think we should keep it as is and not go through creating a new package on pypi

[miguelgfierro]

Happy to revert this, this is like a cosmetic change, so not super important

Just to provide more clarity. with ms-recommenders in the setup.py, we get these two files:

ms_recommenders-0.6.0.post1623931532-py3-none-manylinux1_x86_64.whl  
ms-recommenders-0.6.0.post1623931532.tar.gz

with ms_recommenders in the setup.py, we get this:

ms_recommenders-0.6.0.post1623931532-py3-none-manylinux1_x86_64.whl  
ms_recommenders-0.6.0.post1623931532.tar.gz

The name of the package in pypi is the same: ms-recommenders, I was able to upload to test.pypi the files with ms_recommenders: https://test.pypi.org/project/ms-recommenders/0.6.0.post1623931532/, see here the files: https://test.pypi.org/project/ms-recommenders/0.6.0.post1623931532/#files.

But again, happy to revert this

[gramhagen]

oh ok, i was worried we were proposing a name change to the package. i'm fine with this.