-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CIs in py37 #1518
Run CIs in py37 #1518
Conversation
I suspect that tensorflow upgrade would allow us to upgrade python for venv & virtualenv too, but I am not completely sure. The reason I am not sure is that, while we need numba for some libraries with algos, numba is not included in TF dependencies. But hopefully the higher numpy version will be more compatible with the algos we import. Regarding pip-native solutions, I haven't found anything that applies to our case on the internet, but you are welcome to search more, maybe there is something about this out there. |
7cb3eff
to
9e29652
Compare
Codecov Report
@@ Coverage Diff @@
## staging #1518 +/- ##
===========================================
+ Coverage 62.12% 62.21% +0.08%
===========================================
Files 84 84
Lines 8397 8442 +45
===========================================
+ Hits 5217 5252 +35
- Misses 3180 3190 +10
Continue to review full report at Codecov.
|
Description
Extend the CIs to run the build in 3.7:
pr-gate
runs in python 3.7 only (upgraded from 3.6)nightly
build runs in both 3.6 & 3.7nightly
build runs on dedicated self-hosted machines onlyThanks to @anargyri, we have a solution to this withconda install numpy-base
as documented in this PR #1515. This would require the use of conda in the pipeline that uses virtualenv with tox. I am wondering what would be the minimum changes to the pipeline to incorporate this fix.@anargyri, if I understand from this thread correctly, we have this numba import issue in py37 because of a specific numpy version fixed by Tensorflow, so if we somehow update tensorflow would this go away?Not sure if there are other pip-native solutions to this without involving conda.Update: Thanks to @anargyri, we have a clean pip-native solution to the above problem after #1540 is merged.
Related Issues
#1511
Checklist:
staging branch
and not tomain branch
.